Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a unique dataset ID for each run of BQ system tests. #1131

Merged
merged 1 commit into from
Sep 10, 2015
Merged

Use a unique dataset ID for each run of BQ system tests. #1131

merged 1 commit into from
Sep 10, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 10, 2015

Addresses #1104 (comment)

@tseaver tseaver added testing api: bigquery Issues related to the BigQuery API. labels Sep 10, 2015
@tseaver tseaver mentioned this pull request Sep 10, 2015
Closed
@dhermes
Copy link
Contributor

dhermes commented Sep 10, 2015

LGTM. Can you refresh me where the clean-up of a dataset occurs? How do we make sure test failures don't prevent it?

@tseaver
Copy link
Contributor Author

tseaver commented Sep 10, 2015

Can you refresh me where the clean-up of a dataset occurs? How do we make sure test failures don't prevent it?

https://github.com/GoogleCloudPlatform/gcloud-python/blob/61abd0c8ce00db9784d76589ba7e57c315e32b83/system_tests/bigquery.py#L35

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2015
tseaver added a commit that referenced this pull request Sep 10, 2015
@tseaver
Merge pull request #1131 from tseaver/bigquery-system_tests-unique_da…
219fe75 
…taset

Use a unique dataset ID for each run of BQ system tests.
@tseaver tseaver merged commit 219fe75 into googleapis:master Sep 10, 2015
@tseaver tseaver deleted the bigquery-system_tests-unique_dataset branch September 10, 2015 21:11
@dhermes dhermes mentioned this pull request Sep 30, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot